Skip to content

Conversation

@ehuss
Copy link
Contributor

@ehuss ehuss commented Nov 20, 2023

#13004 bumped the credential crate versions to deal with a semver-incompatible change, but I believe we also need to bump and publish cargo.

My thinking is that:

  • cargo 0.75.0 currently depends on cargo-credential-libsecret="0.3.1"
    • The Cargo.lock is locked to 0.3.2
  • We plan to yank cargo-credential-libsecret 0.3.2
  • Users who depend on cargo 0.75.0 as a library will be unable to do so since after yanking it will pick up cargo-credential-libsecret="0.3.1", but this won't work.
    • cargo 0.75.0 -> cargo-credential 0.4.0
    • cargo-credential-libsecret 0.3.1 -> cargo-credential 0.3.0

(Users using a Cargo.lock, like doing rust builds, shouldn't be affected by the yank.)

So, after publishing the new credential crates, I think we'll also need to publish a new 0.75.1 which depends on the correct versions so that users can use 0.75. It also probably makes sense to yank 0.75.0.

@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2023

r? @weihanglo

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Nov 20, 2023

⚠️ Warning ⚠️

  • Pull requests are usually filed against the master branch for this repo, but this one is against rust-1.74.0. Please double check that you specified the right target!

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 20, 2023
Copy link
Member

@weihanglo weihanglo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I forgot this part 😅

@weihanglo
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Nov 20, 2023

📌 Commit b08c208 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2023
@bors
Copy link
Contributor

bors commented Nov 20, 2023

⌛ Testing commit b08c208 with merge 1308252...

@bors
Copy link
Contributor

bors commented Nov 20, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 1308252 to rust-1.74.0...

@bors bors merged commit 1308252 into rust-lang:rust-1.74.0 Nov 20, 2023
@ehuss ehuss modified the milestones: 1.74, 1.74.0 Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants